Skip to content

Modularized eslint configs and added ability for customizing certain eslint rules per project basis#619

Merged
unnitallman merged 8 commits intomasterfrom
615-custom-eslint-config
Sep 26, 2021
Merged

Modularized eslint configs and added ability for customizing certain eslint rules per project basis#619
unnitallman merged 8 commits intomasterfrom
615-custom-eslint-config

Conversation

@yedhink
Copy link
Copy Markdown
Contributor

@yedhink yedhink commented Sep 22, 2021

Fixes #615, Fixes #620

@unnitallman

Please don't merge yet.

We should only merge this PR after the sync_with_wheel script is ready and neetoCompliance is updated.

@bot-bigbinary bot-bigbinary temporarily deployed to wheel-pr-619 September 22, 2021 11:04 Inactive
@yedhink yedhink temporarily deployed to wheel-pr-619 September 22, 2021 12:51 Inactive
@yedhink yedhink changed the title WIP: Modularized eslint configs and added ability for customizing certain eslint rules per project basis Modularized eslint configs and added ability for customizing certain eslint rules per project basis Sep 23, 2021
@yedhink
Copy link
Copy Markdown
Contributor Author

yedhink commented Sep 23, 2021

@unnitallman

The script is ready: https://gist.github.com/yedhink/d0e88d99536eca2bffb7becab49a0a39

Please note that this script will work once this PR gets merged. The reason is that the .eslint-rules folder gets added to master only once this PR is merged.

In neetoCompliance, the array of configs declared from the script that I've created can be used for auditing.

One more thing to notice here is that when we update the gist, the raw URL only gets updated after like 10 seconds due to caching issue in Github's side. We can counter it to an extent by passing an URL param with a random cache value. Thought I'd point this out.

We can merge this PR once changes are merged in neetoCompliance. Either ways neeto users will have to update neetoCompliance to latest version in order for changes to get reflected. Thus this PR can wait.

@yedhink yedhink temporarily deployed to wheel-pr-619 September 23, 2021 05:32 Inactive
@yedhink
Copy link
Copy Markdown
Contributor Author

yedhink commented Sep 23, 2021

@unnitallman Also, this is how we should add the sync_with_wheel command in package.json.

Users can run the following from terminal after adding above script to package.json to pull latest configs:

yarn run sync_with_wheel

@yedhink yedhink temporarily deployed to wheel-pr-619 September 23, 2021 10:21 Inactive
@yedhink yedhink temporarily deployed to wheel-pr-619 September 23, 2021 15:17 Inactive
@yedhink
Copy link
Copy Markdown
Contributor Author

yedhink commented Sep 23, 2021

@unnitallman As per our discussion, I have moved the script into wheel itself.

This will allow us to update the script with much more ease when say a new config or package is added to wheel.

Will wait till neetoCompliance is ready to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical expressions shouldn't be checked for indentation Add custom eslint option

3 participants