Skip to content

Added support for DIA-NN version 2.1.0#53

Merged
ypriverol merged 5 commits intomainfrom
dev
Apr 20, 2025
Merged

Added support for DIA-NN version 2.1.0#53
ypriverol merged 5 commits intomainfrom
dev

Conversation

@ypriverol
Copy link
Copy Markdown
Member

@ypriverol ypriverol commented Apr 20, 2025

Summary by CodeRabbit

  • New Features
    • Added support for DIA-NN version 2.1.0.
  • Bug Fixes
    • Improved handling of report file formats for different DIA-NN versions, ensuring correct file type is used for all 1.x versions.
  • Chores
    • Updated version number to 0.0.21.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2025

Walkthrough

This update increases the version number of the package from 0.0.20 to 0.0.21 in both the configuration and source files. In addition, the codebase now recognizes DIA-NN version 2.1.0 as valid. The logic for determining how to read the main report file has been refined: instead of excluding versions containing "2.0", the code now explicitly checks if the version starts with "1." to decide the file format and columns to read, ensuring more precise handling of different DIA-NN versions.

Changes

File(s) Change Summary
pyproject.toml, quantmsutils/init.py Incremented version from 0.0.20 to 0.0.21 in both the configuration and source files.
quantmsutils/diann/diann2mztab.py Added support for DIA-NN version 2.1.0; refined logic for reading the main report file based on version.

Poem

Up hopped the version, a step to twenty-one,
DIA-NN grows wiser, new support has begun!
Reports now read smarter, with versions in mind,
The code checks the start, leaving old checks behind.
With numbers aligned and logic anew,
This rabbit’s release is hopping right through!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 467280d and f096815.

📒 Files selected for processing (3)
  • pyproject.toml (1 hunks)
  • quantmsutils/__init__.py (1 hunks)
  • quantmsutils/diann/diann2mztab.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: build (3.10)
  • GitHub Check: build (3.9)
  • GitHub Check: build
🔇 Additional comments (4)
pyproject.toml (1)

6-6: Version increment looks good

The version has been properly incremented from "0.0.20" to "0.0.21", which aligns with the changes made in the codebase, particularly the DIA-NN version 2.1.0 support added in the diann2mztab.py file.

quantmsutils/__init__.py (1)

1-1: Version update is consistent

The version string has been updated from "0.0.20" to "0.0.21", maintaining synchronization with the version in pyproject.toml. This consistency is important for proper package versioning.

quantmsutils/diann/diann2mztab.py (2)

375-376: Successfully added support for DIA-NN version 2.1.0

The list of supported DIA-NN versions has been extended to include version "2.1.0", which properly enables the software to recognize and work with this newer version.


475-480: Improved version detection logic

The logic for determining how to read the main report file has been refined to explicitly check if the version starts with "1." rather than checking if "2.0" is not contained in the version string. This change provides more precise handling of different DIA-NN versions and makes the code more maintainable.

For versions starting with "1.", it reads the report as a TSV file with specific columns plus "MS2.Scan". For all other versions (including 2.x series), it reads a parquet file with those columns plus "Decoy".

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ypriverol ypriverol changed the title Dev Added support for DIA-NN version 2.1.0 Apr 20, 2025
@ypriverol ypriverol merged commit 898e935 into main Apr 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants