Skip to content

Add Peptidoform Scoring Control#13

Merged
ypriverol merged 1 commit intobigbio:yasset-refactoringfrom
yueqixuan:yasset-refactoring
Mar 18, 2026
Merged

Add Peptidoform Scoring Control#13
ypriverol merged 1 commit intobigbio:yasset-refactoringfrom
yueqixuan:yasset-refactoring

Conversation

@yueqixuan
Copy link
Collaborator

Testing completed: (Phase 2) 2d. Phospho: Peptidoform Scoring Control

DIA-NN: (--no-peptidoforms) disables automatic activation of peptidoform scoring when variable modifications are declared, not recommended.

After testing, the DIA-NN log only stops showing "WARNING: peptidoform scoring enabled because variable modifications have been declared; to disable, use --no-peptidoforms : 1" when diann_no_peptidoforms is applied in all subworkflows.

Subworkflows
INSILICO_LIBRARY_GENERATION
PRELIMINARY_ANALYSIS
ASSEMBLE_EMPIRICAL_LIBRARY
INDIVIDUAL_ANALYSIS
FINAL_QUANTIFICATION

New params:

Parameter Type Default
--diann_no_peptidoforms boolean false

Tested (Run PXD026600 with --diann_no_peptidoforms true):

Version Test Passed
2.0
2.1.0
2.2.0
2.3.2

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6945a01-2eb8-4470-9925-8adc64a5ba62

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@ypriverol ypriverol self-requested a review March 18, 2026 09:22
@ypriverol ypriverol merged commit da61329 into bigbio:yasset-refactoring Mar 18, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants