Skip to content

Claude/fix pr 82 q dwst#83

Merged
ypriverol merged 3 commits into
devfrom
claude/fix-pr-82-QDwst
May 5, 2026
Merged

Claude/fix pr 82 q dwst#83
ypriverol merged 3 commits into
devfrom
claude/fix-pr-82-QDwst

Conversation

@ypriverol
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the bigbio/quantmsdiann branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

claude added 2 commits May 5, 2026 05:27
- linting.yml: use && in non-release lint condition so only one of the
  two lint steps runs per PR, and gate PR_number.txt write on a present
  pull_request.number to avoid producing empty/invalid values.
- linting_comment.yml: validate the PR number from the artifact and skip
  the comment step instead of hard-failing when the file is missing,
  empty, or malformed.
- fix_linting.yml: skip the commit step when prek's failure left no
  staged changes so the workflow doesn't fail on an empty commit.
- branch.yml: drop the duplicate "is" in the PR-target failure message.
- .dockstore.yml: restore subclass casing to NFL (Dockstore is
  case-sensitive for Nextflow workflows).
- AGENTS.md: update documented nf-schema version to 2.6.1 to match the
  pin in nextflow.config.

https://claude.ai/code/session_01NegkDFUUqPkuCnE2YJ4oAU
Promote the Unreleased/2.1.0dev section to a dated 2.1.0 entry using the
existing release-name convention (matches the 2.0.0 "Rome" entry).

https://claude.ai/code/session_01NegkDFUUqPkuCnE2YJ4oAU
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db05c338-5208-40e1-93ad-319071e54274

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-pr-82-QDwst

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 74e0dfd

+| ✅ 108 tests passed       |+
#| ❔  18 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-05-05 06:04:29

ThermoRawFileParser already emits indexed mzML (-f=2 default) and the
wiff converter does the same, so the OpenMS FileConverter pass is only
useful for user-supplied pre-built mzML that may be unindexed. DIA-NN
handles unindexed mzML on its own. Flip the default off; users who need
it can opt in with --reindex_mzml true. Schema description and
CHANGELOG updated to call out the migration note.

https://claude.ai/code/session_01NegkDFUUqPkuCnE2YJ4oAU
@ypriverol ypriverol merged commit 1c4328d into dev May 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants