feat: Add hardcoded fallback to each locale message #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the language fails
antobinary
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds new hardcoded messages as a fallback for when the correct message is not even in the
en.jsonlocales.The code might be a little bit duplicated because we have the same message in 2 places (as the default messages are the same as those in
en.json), but from a user perspective, this will help a bunch, as it will avoid displaying the key of the locale message if there was a fail when fetchingen.json, for instance.More
During this PR, a bug was found in
useLocaleMessages, which is: if theen.jsonfile is empty, the change of language doesn't work, this might be happening when merging the fallback messages with the desired messages.en.jsonis empty