Skip to content

[Improvement] : Added disabled option to input element in RolePermissionRow.jsx#6002

Merged
farhatahmad merged 1 commit intobigbluebutton:masterfrom
rautniraj:update-to-edit-role-permission-setting-page
May 7, 2025
Merged

[Improvement] : Added disabled option to input element in RolePermissionRow.jsx#6002
farhatahmad merged 1 commit intobigbluebutton:masterfrom
rautniraj:update-to-edit-role-permission-setting-page

Conversation

@rautniraj
Copy link
Contributor

@rautniraj rautniraj commented Feb 20, 2025

This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state.

This makes sense mostly for the CreateRoom Permission. Because at backend, once this option is enabled not only it performs the update action but also it has chained operation of creating rooms for user. This might take some time in completion and then returning success message, if there are large chunks of users for whom this needs to be done. So consecutive request needs to be handled well.

def create_default_room
	return unless role_params[:name] == 'CreateRoom' && role_params[:value] == true
        User.includes(:rooms)
              .with_provider(current_provider)
              .where(role_id: role_params[:role_id])
              .where(rooms: { id: nil }).find_in_batches do |group|
            group.each do |user|
              Room.create(name: t('room.new_room_name', username: user.name, locale: user.language), user_id: user.id)
            end
          end
  end

This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state
@sonarqubecloud
Copy link

@rautniraj
Copy link
Contributor Author

rautniraj commented Feb 20, 2025

We dont need this disabled option on other settings like role name, recording visibility, room limit

To make this more robust if u feel i will add them as per ur suggestion. Other than these 3, every setting is now equipped with disabled.

@rautniraj rautniraj changed the title Added disabled option to input element in RolePermissionRow.jsx [Improvement] : Added disabled option to input element in RolePermissionRow.jsx May 4, 2025
@farhatahmad farhatahmad merged commit 8edf5d9 into bigbluebutton:master May 7, 2025
4 checks passed
pachidj87 pushed a commit to ZumbTech/Auditorium that referenced this pull request Sep 15, 2025
…luebutton#6002)

This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants