[Improvement] : Added disabled option to input element in RolePermissionRow.jsx#6002
Merged
farhatahmad merged 1 commit intobigbluebutton:masterfrom May 7, 2025
Conversation
This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state
|
Contributor
Author
|
We dont need this disabled option on other settings like role name, recording visibility, room limit To make this more robust if u feel i will add them as per ur suggestion. Other than these 3, every setting is now equipped with disabled. |
farhatahmad
approved these changes
May 7, 2025
pachidj87
pushed a commit
to ZumbTech/Auditorium
that referenced
this pull request
Sep 15, 2025
…luebutton#6002) This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This will prevent piling of multiple POST request to update role permission api simultaneously. We will disable the button when the api is in loading state.
This makes sense mostly for the CreateRoom Permission. Because at backend, once this option is enabled not only it performs the update action but also it has chained operation of creating rooms for user. This might take some time in completion and then returning success message, if there are large chunks of users for whom this needs to be done. So consecutive request needs to be handled well.