Skip to content

Conversation

@muawiakh
Copy link
Contributor

  • Adding python development library and headers as a dependency for
    cryptography.
  • Also reference to official cryptography installation guide.
  • Restructure document

@muawiakh muawiakh self-assigned this Aug 11, 2017
@muawiakh muawiakh requested review from krish7919, sbellem and ttmc and removed request for ttmc August 11, 2017 09:12
Dependency 4: cryptography and cryptoconditions
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

BigchainDB(server and driver) also depend on `cryptography`_ and `cryptoconditions`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depend => depends

* Adding python development library and headers as a dependency for
cryptography.
* Also reference to official cryptography installation guide.
* Restructure document
@muawiakh muawiakh force-pushed the minor-change-dep-bdb-driver branch from ef0515b to 5a2e76e Compare August 11, 2017 09:49
@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files           9        9           
  Lines         236      236           
=======================================
  Hits          234      234           
  Misses          2        2

Copy link
Contributor

@krish7919 krish7919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BigchainDB(server and driver) also depends on `cryptography`_ and `cryptoconditions`_.

* `cryptography`_ depends on `libssl`_, `libcrypto`_ which also depends on (`Python development library and header files`_).
* `cryptoconditions`_ depends on `PyNaCl`_ (`Networking and Cryptography library`_) which depends on ``ffi.h``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BigchainDB Python driver also depends on cryptoconditions which depends on. cryptography and PyNaCl ...

@codegeschrei codegeschrei merged commit e6c0c46 into master Mar 9, 2018
@codegeschrei codegeschrei deleted the minor-change-dep-bdb-driver branch March 9, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants