Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

bugfix: remove duplicate variant metafield and variant id params.#1447

Merged
slsriehl merged 2 commits intobigcommerce:bobbyshaw-merge-queuefrom
bobbyshaw:fix/remove-duplicate-metafield-and-variant-id-params-on-variant-metafields-endpoint
Sep 9, 2023
Merged

bugfix: remove duplicate variant metafield and variant id params.#1447
slsriehl merged 2 commits intobigcommerce:bobbyshaw-merge-queuefrom
bobbyshaw:fix/remove-duplicate-metafield-and-variant-id-params-on-variant-metafields-endpoint

Conversation

@bobbyshaw
Copy link
Contributor

metafield_id and variant_id params only need to be defined at endpoint level. Method level definitions are duplicates.

![Screenshot 2023-09-04 at 12 44 11](https://github.com/bigcommerce/api-specs/assets/553566/62ecabf4-6920-4e72-

9dc1-14ac0ee94847)

[DEVDOCS-]

What changed?

  • remove duplicate metafield_id and variant_id param definitions on variant metafields endpoint

Anything else?

Add related PRs, salient notes, ticket numbers, etc.

ping {names}

metafield_id and variant_id params only need to be defined at endpoint
level. Method level definitions are duplicates.
@slsriehl slsriehl changed the base branch from main to bobbyshaw-merge-queue September 9, 2023 23:11
@slsriehl slsriehl merged commit fa811a4 into bigcommerce:bobbyshaw-merge-queue Sep 9, 2023
@slsriehl slsriehl mentioned this pull request Sep 9, 2023
slsriehl pushed a commit that referenced this pull request Sep 9, 2023
…params. (#1447)

Co-authored-by: Sarah Riehl <sarah.riehl@bigcommerce.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants