Skip to content

BIG-17565 Add function to remove a header from Connection object.#140

Merged
aleachjr merged 1 commit intobigcommerce:masterfrom
bc-ravijayaramappa:BIG-17565
May 6, 2015
Merged

BIG-17565 Add function to remove a header from Connection object.#140
aleachjr merged 1 commit intobigcommerce:masterfrom
bc-ravijayaramappa:BIG-17565

Conversation

@bc-ravijayaramappa
Copy link
Copy Markdown
Contributor

Comment thread src/Bigcommerce/Api/Connection.php Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need the isset check. Technically you don't even need that.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.28%) to 61.11% when pulling 0820b8c on bc-ravijayaramappa:BIG-17565 into 15aaf1b on bigcommerce:master.

@lord2800
Copy link
Copy Markdown
Contributor

lord2800 commented May 6, 2015

👍

@lord2800
Copy link
Copy Markdown
Contributor

lord2800 commented May 6, 2015

Just awaiting Travis now.

@aleachjr
Copy link
Copy Markdown
Contributor

aleachjr commented May 6, 2015

Please do not merge this without adding a test unless you are unable to write one.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.28%) to 61.11% when pulling 0820b8c on bc-ravijayaramappa:BIG-17565 into 15aaf1b on bigcommerce:master.

@lord2800
Copy link
Copy Markdown
Contributor

lord2800 commented May 6, 2015

This is adding a method to the Connection object, which isn't testable at this time.

@bc-ravijayaramappa
Copy link
Copy Markdown
Contributor Author

@aleachjr Merge please?

aleachjr added a commit that referenced this pull request May 6, 2015
BIG-17565 Add function to remove a header from Connection object.
@aleachjr aleachjr merged commit 1b0302d into bigcommerce:master May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants