getSkusByProduct #231
Merged
bookernath merged 3 commits intobigcommerce:masterfrom Sep 11, 2018
Merged
Conversation
lord2800
reviewed
Sep 11, 2018
| } | ||
|
|
||
| /** | ||
| Get collection of product skus by Product |
Contributor
There was a problem hiding this comment.
Can you format this like:
/**
* Get collection of product skus by Product
* @param array $filter
* @return mixed
*/
That way it'll get picked up as a docblock in IDEs like PHPStorm.
lord2800
reviewed
Sep 11, 2018
| * @param $productId | ||
| * @param array $filter | ||
| * @return mixed | ||
| */ |
Contributor
There was a problem hiding this comment.
This one's still out of alignment. :(
msznaper
commented
Sep 11, 2018
Contributor
Author
msznaper
left a comment
msznaper
left a comment
There was a problem hiding this comment.
I hope now it's okay. ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get collection of product skus by Product