Skip to content

feat: prefetch product option on hover#1032

Merged
deini merged 1 commit intomainfrom
deini/prefetch-interaction
Jun 25, 2024
Merged

feat: prefetch product option on hover#1032
deini merged 1 commit intomainfrom
deini/prefetch-interaction

Conversation

@deini
Copy link
Copy Markdown
Contributor

@deini deini commented Jun 25, 2024

What/Why?

On product option hover -> prefetch PDP data. This change makes the UX better at the cost of a few more requests.

This change was only required on multiple choice options, are these are the only ones changing the url.

Testing

Inspect network tab while hovering on product options.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: d35fc71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:29pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:29pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:29pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:29pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:29pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:29pm

@deini deini force-pushed the deini/prefetch-interaction branch from 90efb88 to 9255386 Compare June 25, 2024 17:00
@deini deini marked this pull request as ready for review June 25, 2024 17:02
@deini deini requested a review from a team June 25, 2024 17:02
Comment on lines 44 to 46
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😠

Copy link
Copy Markdown
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-js1ktagor-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@deini deini added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 982b19c Jun 25, 2024
@deini deini deleted the deini/prefetch-interaction branch June 25, 2024 17:33
@github-actions github-actions Bot mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants