feat(core): make fetch channel aware per locale#1055
Conversation
🦋 Changeset detectedLatest commit: 1abc436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
jorgemoya
force-pushed
the
add-dynamic-channel
branch
from
c67c927 to
8d9751d
Compare
There was a problem hiding this comment.
Returning process.env.BIGCOMMERCE_CHANNEL_ID until we can figure out how to programatically detect if getLocale won't work in getChannelId.
jorgemoya
force-pushed
the
add-dynamic-channel
branch
from
8d9751d to
7f0a2a8
Compare
| @@ -1,4 +1,8 @@ | |||
| import { createClient } from '@bigcommerce/catalyst-client'; | |||
| // import { headers } from 'next/headers'; | |||
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-kokmeu7z3-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
2 participants
What/Why?
Add channel <=> locale config example.
Make client.fetch channel aware by fetching channel id assigned to locale.
Fetch from default channel if no map is found.
Testing
Locally, it requests per channel configured.