fix(core): make selected account tab visible for user by default on mobile devices#1056
Merged
bc-yevhenii-buliuk merged 1 commit intomainfrom Jul 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: f3a9903 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
bc-yevhenii-buliuk
force-pushed
the
fix-selected-account-tab
branch
2 times, most recently
from
6349d2a to
0ccca87
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-selected-account-tab
branch
from
0ccca87 to
7f30beb
Compare
bc-yevhenii-buliuk
changed the title
bc-yevhenii-buliuk
force-pushed
the
fix-selected-account-tab
branch
from
7f30beb to
9431130
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-selected-account-tab
branch
from
9431130 to
f3a9903
Compare
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-6c09f0ue0-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
yurytut1993
approved these changes
Jul 5, 2024
chanceaclark
approved these changes
Jul 9, 2024
jorgemoya
approved these changes
Jul 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR makes selected account tab visible for user by default on Mobile devices even after reloading the page.
Testing
locally
before:
account_selected_tab_bug.mov.mov
after:
account_selected_tab_fix.mov