Skip to content

fix(core): add minor changes to address form layout#1086

Merged
bc-alexsaiannyi merged 2 commits intomainfrom
update-address-forms-layout
Jul 15, 2024
Merged

fix(core): add minor changes to address form layout#1086
bc-alexsaiannyi merged 2 commits intomainfrom
update-address-forms-layout

Conversation

@bc-alexsaiannyi
Copy link
Copy Markdown
Contributor

What/Why?

The PR adds changes to address form layout like:

  • gap between form elements reduced to gap-y-3
  • removing top margin on heading;

Testing

locally

Screenshot 2024-07-11 at 14 39 26 Screenshot 2024-07-11 at 14 40 33

@bc-alexsaiannyi bc-alexsaiannyi requested a review from a team July 11, 2024 15:55
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:07am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jul 15, 2024 8:07am
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: af76b31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-7jd6z6o90-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit e0926ee Jul 15, 2024
@bc-alexsaiannyi bc-alexsaiannyi deleted the update-address-forms-layout branch July 15, 2024 08:13
@github-actions github-actions Bot mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants