Skip to content

Move sitemap fetching into the client#1098

Merged
bookernath merged 2 commits intomainfrom
move-sitemap-fetching-to-client
Jul 16, 2024
Merged

Move sitemap fetching into the client#1098
bookernath merged 2 commits intomainfrom
move-sitemap-fetching-to-client

Conversation

@bookernath
Copy link
Copy Markdown
Contributor

@bookernath bookernath commented Jul 16, 2024

What/Why?

Moves sitemap index fetching into the client so it gets the benefits of everything the client offers (such as user agent), as well as making the client more useful within other systems who may also wish to use a sitemap.

I fixed some missing user agents on admin API requests while I was at it and also fixed hardcoded hostnames.

Testing

Preview build + server logs

@bookernath bookernath requested a review from a team July 16, 2024 20:22
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:29pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jul 16, 2024 8:29pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:29pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:29pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:29pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:29pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:29pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: b5e8770

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigcommerce/catalyst-client Minor
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-kxcmrtm6w-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@bookernath
Copy link
Copy Markdown
Contributor Author

bookernath commented Jul 16, 2024

Storefront works ✅
Sitemap works https://catalyst-latest-kxcmrtm6w-bigcommerce-platform.vercel.app/sitemap.xml
Shipping estimator on cart page works ✅
User agents observed in logs ✅

@bookernath bookernath added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 405e791 Jul 16, 2024
@bookernath bookernath deleted the move-sitemap-fetching-to-client branch July 16, 2024 20:43
@github-actions github-actions Bot mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants