Skip to content

feat: add pageSize prop to carousels #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgemoya merged 1 commit into from
Jul 26, 2024
Merged

feat: add pageSize prop to carousels #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions core/components/ui/carousel/carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ type CarouselApi = UseEmblaCarouselType[1];
interface Props extends ComponentPropsWithoutRef<'div'> {
items: ReactNode[];
title: string;
pageSize?: 2 | 3 | 4;
}

const Carousel = ({ className, children, title, items, ...props }: Props) => {
const Carousel = ({ className, children, pageSize = 4, title, items, ...props }: Props) => {
const id = useId();
const titleId = useId();
const itemsPerGroup = 4;
const itemsPerGroup = pageSize;

const [carouselRef, api] = useEmblaCarousel({
loop: true,
Expand Down Expand Up @@ -150,7 +151,10 @@ const Carousel = ({ className, children, title, items, ...props }: Props) => {
aria-label={`${index + 1} of ${groupedItems.length}`}
aria-roledescription="slide"
className={cn(
'grid min-w-0 shrink-0 grow-0 basis-full grid-cols-2 gap-6 px-4 md:grid-cols-4 lg:gap-8',
'grid min-w-0 shrink-0 grow-0 basis-full grid-cols-2 gap-6 px-4 lg:gap-8',
pageSize === 2 && 'md:grid-cols-2',
pageSize === 3 && 'md:grid-cols-3',
pageSize === 4 && 'md:grid-cols-4',
!slidesInView.includes(index) && 'invisible',
)}
id={`${id}-slide-${index + 1}`}
Expand Down