feat: pass ip information to request on non-cacheable requests#1384
Merged
chanceaclark merged 2 commits intomainfrom Sep 18, 2024
Merged
feat: pass ip information to request on non-cacheable requests#1384chanceaclark merged 2 commits intomainfrom
chanceaclark merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 495d3aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
deini
approved these changes
Sep 18, 2024
jorgemoya
approved these changes
Sep 18, 2024
Merged
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-n22wefil9-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
This was referenced Sep 24, 2024
This was referenced Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Passes the customer IP on non-cacheable requests so we can enforce things like rate limiting.
Testing
x-real-ipis the Vercel Server IP, whilex-forwarded-foris my personal IP