Skip to content

Update translations#1392

Merged
jorgemoya merged 2 commits intomainfrom
LOCAL-1444-deliver-translations-2024-09-23-09-31-50
Oct 3, 2024
Merged

Update translations#1392
jorgemoya merged 2 commits intomainfrom
LOCAL-1444-deliver-translations-2024-09-23-09-31-50

Conversation

@bc-svc-local
Copy link
Copy Markdown
Collaborator

@bc-svc-local bc-svc-local commented Sep 23, 2024

This pull request was created automatically. Please check new translations, approve and deliver them.

@bc-svc-local bc-svc-local requested a review from a team September 23, 2024 09:31
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:30pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:30pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:30pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:30pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:30pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:30pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:30pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 33d5a62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

BC-krasnoshapka
BC-krasnoshapka previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge until we investigate some of the missing translations.

@chanceaclark chanceaclark force-pushed the LOCAL-1444-deliver-translations-2024-09-23-09-31-50 branch from 8f0c964 to 3410c0f Compare October 1, 2024 15:09
@jorgemoya jorgemoya force-pushed the LOCAL-1444-deliver-translations-2024-09-23-09-31-50 branch from 3410c0f to 33d5a62 Compare October 3, 2024 15:28
@jorgemoya jorgemoya enabled auto-merge October 3, 2024 15:29
@jorgemoya
Copy link
Copy Markdown
Contributor

jorgemoya commented Oct 3, 2024

We will merge these PRs even with the missing translations, can still be used for investigation purposes.

@jorgemoya jorgemoya dismissed BC-krasnoshapka’s stale review October 3, 2024 15:30

We will merge these PRs even with the missing translations, can still be used for investigation purposes.

@jorgemoya jorgemoya added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 76227ac Oct 3, 2024
@jorgemoya jorgemoya deleted the LOCAL-1444-deliver-translations-2024-09-23-09-31-50 branch October 3, 2024 15:33
@github-actions github-actions Bot mentioned this pull request Oct 2, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-f9d0g41jd-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 80
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

This was referenced Oct 7, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

@BC-krasnoshapka BC-krasnoshapka Awaiting requested review from BC-krasnoshapka

Assignees

No one assigned

Labels

update-translations-svc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bc-svc-local @jorgemoya @BC-krasnoshapka @chanceaclark