fix(core): improve create account form#1454
Merged
bc-yevhenii-buliuk merged 3 commits intomainfrom Oct 22, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 658e946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
cba025b to
da8badb
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
da8badb to
3448a09
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
3448a09 to
7fa9652
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
7fa9652 to
63c8b09
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
63c8b09 to
ce9018a
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
befd256 to
ea25fac
Compare
bc-yevhenii-buliuk
force-pushed
the
improve-create-account-form
branch
from
ea25fac to
35ecde2
Compare
yurytut1993
approved these changes
Oct 21, 2024
bc-azvierieva
force-pushed
the
improve-create-account-form
branch
from
bb1bf14 to
658e946
Compare
Merged
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-2mro4sciq-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR improves create account form, namely it removes unnecessary fields from create account form.
Also this PR adds empty state to addresses page.
Testing
locally
before:
after:
with default fields:
improve_create_account_form.mov
with custom fields in Account Signup Fields :
improve_create_account_form_with_custom_fields.mov
with custom field in Account Signup Fields and Address Fields:
custom_fields_in_create_account_form.mov
empty state on the Addresses Page: