Skip to content

fix(core): counter component not showing value#1467

Merged
deini merged 1 commit intomainfrom
fix/counter
Oct 16, 2024
Merged

fix(core): counter component not showing value#1467
deini merged 1 commit intomainfrom
fix/counter

Conversation

@deini
Copy link
Copy Markdown
Contributor

@deini deini commented Oct 15, 2024

What/Why?

Fixes an issue when a numeric product option is set to a minimum <= 0 breaks the counter component.

Testing

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 1365a3f2945f175e751a85c337123c0b22617fb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 4:12pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 16, 2024 4:12pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:12pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:12pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:12pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:12pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:12pm

@deini deini marked this pull request as ready for review October 16, 2024 16:09
@deini deini requested a review from a team October 16, 2024 16:09
@deini deini added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit e763a83 Oct 16, 2024
@deini deini deleted the fix/counter branch October 16, 2024 16:20
@github-actions github-actions Bot mentioned this pull request Oct 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-baktwrlyd-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants