Skip to content

chore(core): dont render breadcrumbs for top level categories#1477

Merged
deini merged 1 commit intomainfrom
hide-top-level-breadcrumb
Oct 17, 2024
Merged

chore(core): dont render breadcrumbs for top level categories#1477
deini merged 1 commit intomainfrom
hide-top-level-breadcrumb

Conversation

@deini
Copy link
Copy Markdown
Contributor

@deini deini commented Oct 17, 2024

What/Why?

Breadcrumbs for top level category pages are no longer rendered

Testing

26ABnIIg@2x

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 8815c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:07pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm
catalyst-au ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm
catalyst-test-store ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm
catalyst-uk ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm
catalyst-unstable ⬜️ Ignored (Inspect) Oct 17, 2024 7:07pm

@deini deini marked this pull request as ready for review October 17, 2024 19:11
@deini deini requested a review from a team October 17, 2024 19:11
@deini deini added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 79e705f Oct 17, 2024
@deini deini deleted the hide-top-level-breadcrumb branch October 17, 2024 19:32
@github-actions github-actions Bot mentioned this pull request Oct 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-2qau1adp1-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 77
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants