Skip to content

Update CLI scopes#1478

Merged
bookernath merged 1 commit intomainfrom
cli-scopes
Oct 17, 2024
Merged

Update CLI scopes#1478
bookernath merged 1 commit intomainfrom
cli-scopes

Conversation

@bookernath
Copy link
Copy Markdown
Contributor

@bookernath bookernath commented Oct 17, 2024

What/Why?

Update scopes requested by CLI

  • Remove cart (no longer needed)
  • Add both storefront API token scopes to ease transition to customer access tokens

Testing

Tested locally

@bookernath bookernath requested a review from a team October 17, 2024 19:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 9bee4c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:20pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 17, 2024 7:20pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 7:20pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 7:20pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 7:20pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 7:20pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 7:20pm

Copy link
Copy Markdown
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally fine with the adding of the store_storefront_api but it's not really needed tbh... I am adding it in #1262 and I "ease" people into it per each commit on that PR

@bookernath bookernath added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 7d66252 Oct 17, 2024
@bookernath bookernath deleted the cli-scopes branch October 17, 2024 19:32
@github-actions github-actions Bot mentioned this pull request Oct 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-hik7zuim5-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 82
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants