Conversation
🦋 Changeset detectedLatest commit: 2f0a414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
| params: Promise<{ slug: string; locale: LocaleType }>; | ||
| } | ||
|
|
||
| export async function generateMetadata(props: Props): Promise<Metadata> { |
There was a problem hiding this comment.
This one took a while to figure out. Turns out our generateMetadata from the dynamic page (which we used to re-export) is using searchParams, which causes this static page to be considered dynamic even if we use force-static.
Hard to track as this doesn't fail on dev, only in production builds.
Had to duplicate this fn and remove the usage of searchParams, since it's a static page we never hit it if we have searchParams set anyway.
I would like to know how this used to work in Next 14 and if there are plans to add searchParams to the list of force-static and return empty on static builds.
The odd thing is that the page does use searchParams 🤔 but only generateMetadata fails.
| rules: { | ||
| 'react/react-in-jsx-scope': 'off', | ||
| 'react/prefer-read-only-props': 'off', | ||
| 'react/destructuring-assignment': 'off', |
There was a problem hiding this comment.
With the new changes to Next 15 you need to await things like searchParams and params. Destructuring props makes this a bit annoying in some scenarios.
| if (typeof window !== 'undefined') { | ||
| bodl.initialize(); | ||
| } |
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-mxwtzks7p-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
* Revert "chore(core): downgrade next (#1513)" This reverts commit ea01e3b. * Revert "feat(core): Next 15 upgrade (#1508)" This reverts commit 3ebb617. * chore(core): bump next-intl * chore(core): only initialize bodl on browsers * fix(tests): remove 'Other' section test * fix(func): Update badge snapshot --------- Co-authored-by: Anudeep Vattipalli <anudeep.vattipalli@bigcommerce.com>
3 participants
What/Why?
Upgrade to Next 15, started with codemods and did many manual changes.
Testing
CI 👀