fix(core): improve error message on reset password page#1520
Merged
bc-alexsaiannyi merged 2 commits intomainfrom Nov 4, 2024
Merged
fix(core): improve error message on reset password page#1520bc-alexsaiannyi merged 2 commits intomainfrom
bc-alexsaiannyi merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 009fc8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
bc-alexsaiannyi
force-pushed
the
fix-reset-password-validation-err
branch
from
1f3b01d to
fb33f6a
Compare
bc-alexsaiannyi
force-pushed
the
fix-reset-password-validation-err
branch
from
fb33f6a to
4a09ddc
Compare
yurytut1993
approved these changes
Oct 31, 2024
bc-alexsaiannyi
force-pushed
the
fix-reset-password-validation-err
branch
from
4a09ddc to
a2f650f
Compare
bc-yevhenii-buliuk
approved these changes
Oct 31, 2024
bc-azvierieva
approved these changes
Nov 1, 2024
Merged
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-c8bskcewf-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR improves validation error on Reset Password form for User. Previously Zod Error was an array of data that was quite hard to read through so we've transformed it into a message where User can read about invalid field and reason for appeared error.
Testing
locally
reset_password_before.mov
reset_password_after.mov