Skip to content

fix(core): fix styles for active account tab#1521

Merged
chanceaclark merged 1 commit intomainfrom
fix-active-account-tab
Nov 4, 2024
Merged

fix(core): fix styles for active account tab#1521
chanceaclark merged 1 commit intomainfrom
fix-active-account-tab

Conversation

@bc-yevhenii-buliuk
Copy link
Copy Markdown
Contributor

What/Why?

This PR fixes styles for active account tab

Testing

locally

before:

fix_active_account_tab_before.mov

after:

fix_active_account_tab_after.mov

@bc-yevhenii-buliuk bc-yevhenii-buliuk requested a review from a team October 29, 2024 13:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: fd48ba3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 0:35am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 1, 2024 0:35am
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 0:35am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 0:35am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 0:35am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 0:35am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 0:35am

Copy link
Copy Markdown
Contributor

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just interested if it keeps active tab after page reload. I remember that Ana's been asking for that some time ago)

@bc-yevhenii-buliuk
Copy link
Copy Markdown
Contributor Author

Looks good. Just interested if it keeps active tab after page reload. I remember that Ana's been asking for that some time ago)

yep, because active tab appearance based on url

Copy link
Copy Markdown
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chanceaclark chanceaclark added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit fd83a78 Nov 4, 2024
@chanceaclark chanceaclark deleted the fix-active-account-tab branch November 4, 2024 13:37
@github-actions github-actions Bot mentioned this pull request Nov 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-rj35e19rz-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants