fix(core): fix validation message for email on account settings page#1529
Merged
chanceaclark merged 1 commit intomainfrom Nov 4, 2024
Merged
fix(core): fix validation message for email on account settings page#1529chanceaclark merged 1 commit intomainfrom
chanceaclark merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6600b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
bc-yevhenii-buliuk
force-pushed
the
fix-account-settings-validation-message
branch
from
6bd054e to
6600b28
Compare
yurytut1993
approved these changes
Nov 1, 2024
chanceaclark
approved these changes
Nov 3, 2024
Merged
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-6ek56r084-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR adds validation message after an incorrectly entered email
Testing
locally
before:
fix-account-settings-validation-message_before.mov
after:
fix-account-settings-validation-message_after.mov