Skip to content

fix: use cookies() inside Header instead of an async function#1856

Merged
agurtovoy merged 1 commit intosoul/integrations/makeswiftfrom
aleksey/fix-ppr-500-error
Jan 7, 2025
Merged

fix: use cookies() inside Header instead of an async function#1856
agurtovoy merged 1 commit intosoul/integrations/makeswiftfrom
aleksey/fix-ppr-500-error

Conversation

@agurtovoy
Copy link
Copy Markdown
Contributor

What/Why?

Applying #1850 to soul/integration/makeswift.

Testing

Cart count

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 57d541c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 11:52pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 11:52pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 6, 2025 11:52pm
catalyst-au ⬜️ Ignored (Inspect) Jan 6, 2025 11:52pm
catalyst-uk ⬜️ Ignored (Inspect) Jan 6, 2025 11:52pm

@agurtovoy agurtovoy marked this pull request as ready for review January 6, 2025 23:53
@agurtovoy agurtovoy requested a review from a team as a code owner January 6, 2025 23:53
@agurtovoy agurtovoy requested a review from migueloller January 6, 2025 23:53
@agurtovoy agurtovoy merged commit 40cf2cf into soul/integrations/makeswift Jan 7, 2025
@agurtovoy agurtovoy deleted the aleksey/fix-ppr-500-error branch January 7, 2025 00:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ntw6yacfc-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟢 Best practices 100
🟢 SEO 91

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 57
🟢 Accessibility 92
🟢 Best practices 100
🟢 SEO 92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants