feat(cli): monorepo changes required to run create-catalyst CLI#457
Merged
matthewvolk merged 7 commits intomainfrom Jan 31, 2024
Merged
feat(cli): monorepo changes required to run create-catalyst CLI#457matthewvolk merged 7 commits intomainfrom
create-catalyst CLI#457matthewvolk merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewvolk
commented
Jan 30, 2024
matthewvolk
force-pushed
the
create-catalyst-template
branch
from
39fd2d4 to
4a92445
Compare
matthewvolk
force-pushed
the
create-catalyst-template
branch
from
4a92445 to
b240fb1
Compare
matthewvolk
commented
Jan 30, 2024
Contributor
Author
There was a problem hiding this comment.
Without this, building storybook crashes with an error:
Error: [vite]: Rollup failed to resolve import "~/lib/utils" from "catalyst/packages/reactant/src/components/Input/Input.tsx".
b240fb1 to
6b0ea13
Compare
matthewvolk
force-pushed
the
create-catalyst-template
branch
from
6b0ea13 to
d082955
Compare
matthewvolk
force-pushed
the
create-catalyst-template
branch
from
d082955 to
05b497b
Compare
jorgemoya
approved these changes
Jan 31, 2024
deini
approved these changes
Jan 31, 2024
Contributor
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-rnz602pym-bigcommerce-platform.vercel.app/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
cnin Reactant must be throughtsconfigpaths. This allows components to be copied over intoapps/corewithout needing to modifycnreferences.dotenv-clitoapps/coreso thatcodegenanddev-codegenpackage scripts can be run outside of the monorepo.tsconfigpath inapps/coreto map references to@bigcommerce/reactant/*to./node_modules/@bigcommerce/reactant/*. When thecreate-catalystCLI creates the new projecttsconfig, this path is mapped to./components/ui/*where the Reactant components are copied into.tsconfigpath inpackages/reactantto allow references tocninsidepackages/reactantto be the same as references tocnfrom withinapps/core.apps/core/userAgent.tscannot reference monorepopackage.jsonoutside of the monorepo.packages/reactant/.eslintrc.cjsandapps/core/.eslintrc.cjsso that we can have a single.eslintrc.cjsto use while Catalyst is running outside of the monorepo.packages/reactant/tailwind.config.jsandapps/core/tailwind.config.jsso that we can have a singletailwind.config.jsto use while Catalyst is running outside of the monorepo.Testing
https://bigcommerce.slack.com/archives/C056HLZC36W/p1706286802069659?thread_ts=1706213429.702309&cid=C056HLZC36W