Skip to content

fix(core): check for auth on account pages#773

Merged
deini merged 1 commit intomainfrom
fix/login
Apr 16, 2024
Merged

fix(core): check for auth on account pages#773
deini merged 1 commit intomainfrom
fix/login

Conversation

@deini
Copy link
Copy Markdown
Contributor

@deini deini commented Apr 16, 2024

What/Why?

Check for auth in all child pages of /account. Currently accessing /account/settings without being logged in will still render the page.

Testing

Navigating to /account/settings redirects to /login when not logged in.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 052cadf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:42pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:42pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 7:42pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 7:42pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 7:42pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 7:42pm

@deini deini marked this pull request as ready for review April 16, 2024 19:40
@deini deini requested a review from a team April 16, 2024 19:40
@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-k2swh7uhy-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

@deini deini added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 7f70719 Apr 16, 2024
@deini deini deleted the fix/login branch April 16, 2024 19:52
@github-actions github-actions Bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants