Skip to content

feat(cli): copy vscode ts settings#782

Merged
chanceaclark merged 1 commit intomainfrom
feat/vscode-settings
Apr 17, 2024
Merged

feat(cli): copy vscode ts settings#782
chanceaclark merged 1 commit intomainfrom
feat/vscode-settings

Conversation

@chanceaclark
Copy link
Copy Markdown
Contributor

What/Why?

Creates the .vscode/settings.json file pointing to the Typescript SDK. This will help with new repos getting better TS support for gql-tada locally.

Testing

Screenshot 2024-04-17 at 14 33 50

@chanceaclark chanceaclark requested a review from a team April 17, 2024 18:38
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: c16a939

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:24pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:24pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:24pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:24pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:24pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:24pm

Comment thread packages/create-catalyst/src/index.ts Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thought here is that maybe we will support other editors TS servers.

Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Originally I was thinking we should prompt and ask if they want the settings file created, but I like this way more, as it's extensible to other editors - and, there's probably never a reason they wouldn't want editor-specific config files created.

Comment thread packages/create-catalyst/src/index.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-p8nyj1i80-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

@chanceaclark chanceaclark added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 32f9d7c Apr 17, 2024
@chanceaclark chanceaclark deleted the feat/vscode-settings branch April 17, 2024 19:37
@github-actions github-actions Bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants