Skip to content

feat(core): add delete address functionality for account#787

Merged
bc-alexsaiannyi merged 1 commit intomainfrom
delete-address
May 16, 2024
Merged

feat(core): add delete address functionality for account#787
bc-alexsaiannyi merged 1 commit intomainfrom
delete-address

Conversation

@bc-alexsaiannyi
Copy link
Copy Markdown
Contributor

@bc-alexsaiannyi bc-alexsaiannyi commented Apr 18, 2024 •
edited
Loading

What/Why?

This PR brings delete address functionality for Account.

Testing

locally

@bc-alexsaiannyi bc-alexsaiannyi requested a review from a team April 18, 2024 14:05
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-au 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:04am
catalyst-core ❌ Failed (Inspect) May 16, 2024 10:04am
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:04am
catalyst-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:04am
catalyst-test-store 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:04am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 10:04am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 10:04am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b20168c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bc-alexsaiannyi
bc-alexsaiannyi commented Apr 18, 2024
View reviewed changes
Comment thread apps/core/app/[locale]/(default)/(faceted)/_components/pagination.tsx Outdated
Comment on lines 31 to 34
Copy link
Copy Markdown
Contributor Author

@bc-alexsaiannyi bc-alexsaiannyi Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I've experienced issues with navigation on deleting last item on page (like Customer's address). After the action I've received url like https://your-store/addresses?before=null which prevents smooth navigation afterwards. So I've put this condition and if there is no cursor we just basically return start position for pagination.

avattipalli
avattipalli reviewed Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@avattipalli avattipalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please attach a PoL to this PR?

Comment thread apps/core/messages/en.json Outdated
Copy link
Copy Markdown
Contributor

@avattipalli avattipalli Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 We can probably change this to Are you sure you want to delete address? or Are you sure? if we show the Delete Address somewhere within the dialog

Copy link
Copy Markdown
Contributor Author

@bc-alexsaiannyi bc-alexsaiannyi Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Anudeep. It's updated.

Comment thread apps/core/app/[locale]/(default)/account/[tab]/_actions/delete-address.ts Outdated
Copy link
Copy Markdown
Contributor

@avattipalli avattipalli Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 This address has been deleted

@bc-alexsaiannyi bc-alexsaiannyi changed the title feat(core): add delete address functionality for account feat(core): add delete/add address functionality for account Apr 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-n8umgdnq3-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 6198648 May 16, 2024
@bc-alexsaiannyi bc-alexsaiannyi deleted the delete-address branch May 16, 2024 10:14
@github-actions github-actions Bot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

@chanceaclark chanceaclark chanceaclark approved these changes

+2 more reviewers

@avattipalli avattipalli avattipalli left review comments

@yurytut1993 yurytut1993 yurytut1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bc-alexsaiannyi @jorgemoya @chanceaclark @avattipalli @yurytut1993