feat(cli): add option to include functional test suite#806
Conversation
🦋 Changeset detectedLatest commit: 30e36bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
chanceaclark
left a comment
chanceaclark
left a comment
There was a problem hiding this comment.
I still need to see if there are any other TSConfig things that might need to changed, but that will have to wait till we have a small example of the tests running in apps/core.
chanceaclark
added
do not merge
and removed
do not merge
draft
chanceaclark
force-pushed
the
feat/functional-cli
branch
from
5cdc6c4 to
6547352
Compare
There was a problem hiding this comment.
Using regex instead as it could be multi-lined. Pretty sure eslint --fix will take care of the formatting. If not we can always revisit it and do some cleanup here.
There was a problem hiding this comment.
Here were the regex test cases I used:
chanceaclark
force-pushed
the
feat/functional-cli
branch
from
6547352 to
30e36bf
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-1wbzr5qv6-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
3 participants
What/Why?
Adds the ability to include the functional test suite when creating a Catalyst repo from the CLI. We are about to migrate the tests over to the core app which this PR adds some preparation for it from the CLI perspective.
Warning
Just note that the functional test suite won't actually be included until we port it over. This is prep work for it actually being added.
Testing