chore(cli): remove cloning logic for components#839
Conversation
🦋 Changeset detectedLatest commit: e1218d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| compilerOptions: z | ||
| .object({ | ||
| declaration: z.boolean().optional(), | ||
| declarationMap: z.boolean().optional(), | ||
| }) | ||
| .passthrough(), |
There was a problem hiding this comment.
I think we should be able to remove this bit now (and the delete statements below).
| include: z.array(z.string()).optional(), | ||
| }) | ||
| .passthrough() | ||
| .parse(merge({}, readJsonSync(join(projectDir, 'tsconfig.json')))); |
There was a problem hiding this comment.
🍹 I wonder if we still need to merge these now? Could we just read the file then parse it?
| delete packageJson.private; | ||
| delete packageJson.exports; | ||
| delete packageJson.sideEffects; |
There was a problem hiding this comment.
I would audit these, in case we can remove more.
There was a problem hiding this comment.
Do these even get added? Since I removed above, I think I can just remove these, no?
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-22hzzw9lq-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
3 participants
What/Why?
Since we no longer have
/packages/components, we don't need to clone it.Testing
TBD