Skip to content

fix(core): hover text when remove product button is loading#972

Merged
jorgemoya merged 1 commit intomainfrom
fix-loading-text-color
Jun 3, 2024
Merged

fix(core): hover text when remove product button is loading#972
jorgemoya merged 1 commit intomainfrom
fix-loading-text-color

Conversation

@jorgemoya
Copy link
Copy Markdown
Contributor

What/Why?

Hover state wasn't being overriden with the desired color.

Testing

Locally.

Screenshot 2024-06-03 at 1 25 25 PM

@jorgemoya jorgemoya requested a review from a team June 3, 2024 18:27
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:27pm
catalyst-ppr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:27pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Jun 3, 2024 6:27pm
catalyst-au ⬜️ Ignored (Inspect) Jun 3, 2024 6:27pm
catalyst-test-store ⬜️ Ignored (Inspect) Jun 3, 2024 6:27pm
catalyst-uk ⬜️ Ignored (Inspect) Jun 3, 2024 6:27pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: f473265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-qhsummhvq-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 3c34e27 Jun 3, 2024
@jorgemoya jorgemoya deleted the fix-loading-text-color branch June 3, 2024 19:47
@github-actions github-actions Bot mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants