Skip to content

Add RDFa tags to breadcrumbs#1045

Closed
paulhennell wants to merge 1 commit into
bigcommerce:masterfrom
paulhennell:RDFa-Breadcrumbs
Closed

Add RDFa tags to breadcrumbs#1045
paulhennell wants to merge 1 commit into
bigcommerce:masterfrom
paulhennell:RDFa-Breadcrumbs

Conversation

@paulhennell
Copy link
Copy Markdown

What?

Add the RDFa BreadcrumbList markup to the generated breadcrumbs to help Google (and other web crawlers) understand the shop categories better.

Documentation

Follows the schema.org breadcrumb markup guidelines, and passes Google's structured data testing tool. Both appear to suggest using OL instead of UL for the list element, but it validates as is and sticking with UL seems preferable to avoid potential css issues.

Screenshots
Google's testing tool before the markup - no breadcrumbs only product data detected:
screenshot 2017-07-14 14 01 10
Same page after the markup - breadcrumbs now found:
screenshot 2017-07-14 14 01 24

Add RDFa tag markup based on schema.org BreadcrumbList
@paulhennell paulhennell changed the title Add RDFa tags Add RDFa tags to breadcrumbs Jul 18, 2017
@junedkazi
Copy link
Copy Markdown
Contributor

@hennell-git thank you for your contribution. Can you please give some information about the 4 errors I see in the screenshot ?

@paulhennell
Copy link
Copy Markdown
Author

The 4 errors are part of the product markup section - this fix only adds the detected BreadcrumbList section which is error free!

(I was actually investigating our product section errors originally, but that's more complex as the product data might not be supplied by the user which leads to the errors above as data is marked but missing - added in the breadcrumbs code first as it's entirely database generated so can't have those same 'missing elements' issues.)

@PreciselyAlyss PreciselyAlyss requested a review from davidchin July 25, 2017 18:29
@davidchin
Copy link
Copy Markdown
Contributor

Nice work! Thanks for making this change. I have a question for you. I think we use Microdata instead of RDFa in this project. Is there a reason why you choose to use RDFa? If there isn't a special reason, I'd like to keep the format consistent.

@paulhennell
Copy link
Copy Markdown
Author

I'd like to say there's a complex technical reason, but it's actually just based on the fact I've only ever used RDFa, and didn't really think about it or notice the existing product tagging was in microdata!

No idea if there's any actual significant difference between the two and evidently they can work together, but I'd agree it would make sense for the format to be consistent across the whole project.

@davidchin
Copy link
Copy Markdown
Contributor

Ah ok cool, yeah when you have time, can you please update it? Thanks!

@abrambailey
Copy link
Copy Markdown

Hey guys, didn't realize this was a thing, and just submitted a json ld update here #1079

@abrambailey
Copy link
Copy Markdown

image

@mjschock
Copy link
Copy Markdown
Contributor

mjschock commented Mar 1, 2018

closing in favor of #1175

@mjschock mjschock closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants