STRF-14251 Make cart preview work with multi-lang#2627
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Cornerstone’s cart-related Stencil Utils calls to include a baseUrl, so cart preview / cart refresh content is rendered with the correct cart + checkout URLs in multi-language storefronts.
Changes:
- Pass
baseUrlintoutils.api.cart.getContent(...)calls for cart preview, PDP add-to-cart preview, and cart page refresh. - Add a Draft changelog entry documenting the multi-language cart preview fix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/js/theme/global/cart-preview.js | Adds baseUrl: secureBaseUrl to cart preview getContent call to ensure rendered links use the correct localized base URL. |
| assets/js/theme/common/product-details.js | Adds baseUrl: this.context.secureBaseUrl when fetching cart preview content after add-to-cart. |
| assets/js/theme/cart.js | Adds baseUrl: this.context.secureBaseUrl when refreshing cart page partials via getContent. |
| CHANGELOG.md | Adds Draft entry for STRF-14251 describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bc-yevhenii-buliuk
approved these changes
Mar 26, 2026
bc-alexsaiannyi
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We need to properly render cart and checkout urls for cartPreview.
Requirements
Tickets / Documentation
https://bigcommercecloud.atlassian.net/browse/STRF-14251
Screenshots (if appropriate)
Attach images or add image links here.