Skip to content

Revert "Revert "DEVDOCS-6015: [Update] upc, mpn, gtin (#401)"" #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bc-traciporter merged 5 commits into from
Aug 14, 2024
Merged

Revert "Revert "DEVDOCS-6015: [Update] upc, mpn, gtin (#401)"" #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d83ca5
Revert "Revert "DEVDOCS-6015: [Update] upc, mpn, gtin (#401)" (#422)"
bc-traciporter Aug 12, 2024
f0049fb
change length of string to 14
bc-traciporter Aug 12, 2024
23aab7a
Update product-variants_catalog to nullable true
bc-traciporter Aug 12, 2024
7e3a94f
Update products_catalog.v3.yml [max length to 14]
bc-traciporter Aug 12, 2024
5c82c31
Merge branch 'main' into revert-422-revert-401-DEVDOCS-6015
bc-traciporter Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions reference/catalog/product-variants_catalog.v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,9 @@ paths:
upc:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
x-nullable: true
nullable: true
maxLength: 14
minLength: 0
inventory_level:
type: integer
description: |-
Expand Down Expand Up @@ -1347,7 +1349,9 @@ paths:
upc:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
x-nullable: true
nullable: true
maxLength: 14
minLength: 0
example: "1234"
inventory_level:
type: integer
Expand Down Expand Up @@ -1472,7 +1476,9 @@ paths:
upc:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
x-nullable: true
nullable: true
maxLength: 14
minLength: 0
inventory_level:
type: integer
description: |-
Expand Down Expand Up @@ -1990,6 +1996,8 @@ components:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
nullable: true
maxLength: 14
minLength: 0
image_url:
type: string
description: Publicly available image url
Expand Down Expand Up @@ -2019,9 +2027,13 @@ components:
mpn:
type: string
description: The Manufacturer Part Number (MPN) for the variant.
nullable: true
gtin:
type: string
example: '012345678905'
nullable: true
maxLength: 14
minLength: 0
description: Common Variant properties.
x-internal: false
x-examples:
Expand Down Expand Up @@ -2187,6 +2199,8 @@ components:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
nullable: true
maxLength: 14
minLength: 0
inventory_level:
type: integer
description: |-
Expand Down Expand Up @@ -2217,10 +2231,14 @@ components:
type: string
description: Global Trade Item Number
example: '012345678905'
nullable: true
maxLength: 14
minLength: 0
mpn:
type: string
description: Manufacturer Part Number
example: HV-HM02
nullable: true
description: Common Variant properties.
- type: object
properties:
Expand Down
26 changes: 22 additions & 4 deletions reference/catalog/products_catalog.v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5370,7 +5370,9 @@ components:
upc:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
nullable: true
nullable: false
maxLength: 14
minLength: 0
inventory_level:
type: integer
description: |-
Expand All @@ -5397,9 +5399,13 @@ components:
mpn:
type: string
description: The Manufacturer Part Number (MPN) for the variant.
nullable: false
gtin:
type: string
example: '012345678905'
nullable: false
maxLength: 14
minLength: 0
description: Common Variant properties.
x-internal: false
x-examples:
Expand Down Expand Up @@ -5565,7 +5571,9 @@ components:
upc:
type: string
description: The UPC code used in feeds for shopping comparison sites and external channel integrations.
nullable: true
nullable: false
maxLength: 14
minLength: 0
inventory_level:
type: integer
description: |-
Expand Down Expand Up @@ -7127,8 +7135,9 @@ components:
The layout template file used to render this product category. This field is writable only for stores with a Blueprint theme applied. For stores with a Stencil theme applied, see [Custom Template Associations](/docs/rest-content/custom-template-associations).
upc:
type: string
maxLength: 32
maxLength: 14
minLength: 0
nullable: false
description: |
The product UPC code, which is used in feeds for shopping comparison sites and external channel integrations.
search_keywords:
Expand Down Expand Up @@ -7293,9 +7302,13 @@ components:
gtin:
type: string
description: Global Trade Item Number
nullable: false
maxLength: 14
minLength: 0
mpn:
type: string
description: Manufacturer Part Number
nullable: false
date_last_imported:
type: string
description: the date when the Product had been imported
Expand Down Expand Up @@ -7615,8 +7628,9 @@ components:
The layout template file used to render this product category. This field is writable only for stores with a Blueprint theme applied. For stores with a Stencil theme applied, see [Custom Template Associations](/docs/rest-content/custom-template-associations).
upc:
type: string
maxLength: 32
maxLength: 14
minLength: 0
nullable: false
description: |
The product UPC code, which is used in feeds for shopping comparison sites and external channel integrations.
search_keywords:
Expand Down Expand Up @@ -7781,9 +7795,13 @@ components:
gtin:
type: string
description: Global Trade Item Number
nullable: false
maxLength: 14
minLength: 0
mpn:
type: string
description: Manufacturer Part Number
nullable: false
date_last_imported:
type: string
description: the date when the Product had been imported
Expand Down