Skip to content

[DEVDOCS-5379]: [update] OrdersV2, Order/id/ PUT needs clarification about the default behavior in the description#60

Merged
bc-tgomez merged 4 commits intomainfrom
DEVDOCS-5379
Jan 26, 2024
Merged

[DEVDOCS-5379]: [update] OrdersV2, Order/id/ PUT needs clarification about the default behavior in the description#60
bc-tgomez merged 4 commits intomainfrom
DEVDOCS-5379

Conversation

@bc-tgomez
Copy link
Contributor

@bc-tgomez bc-tgomez commented Jan 26, 2024

DEVDOCS-5379

What changed?

  • Add the default PUT behavior for OrdersV2 in the endpoint description

Release notes draft

  • Does this need one if it's an omission?

Anything else?

ping @bc-vincent-zhao

@bc-tgomez bc-tgomez added ready for review This PR is complete and awaiting a review. need-SME-review A subject matter expert is needed to review. labels Jan 26, 2024
@bc-tgomez bc-tgomez self-assigned this Jan 26, 2024
@bc-tgomez
Copy link
Contributor Author

@bc-vincent-zhao Hey there! Would you mind verifying the statement added to the endpoint? If there's an issue would you mind pointing it out?

@bc-tgomez bc-tgomez dismissed bc-traciporter’s stale review January 26, 2024 20:19

The merge-base changed after approval.

bc-traciporter
bc-traciporter previously approved these changes Jan 26, 2024
Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a suggestion, you can take it or leave it.

bc-tgomez and others added 2 commits January 26, 2024 16:15
Co-authored-by: Traci Porter <traci.porter@bigcommerce.com>
bc-traciporter
bc-traciporter previously approved these changes Jan 26, 2024
Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-tgomez bc-tgomez dismissed bc-traciporter’s stale review January 26, 2024 22:37

The merge-base changed after approval.

bc-traciporter
bc-traciporter previously approved these changes Jan 26, 2024
Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@bc-tgomez bc-tgomez dismissed bc-traciporter’s stale review January 26, 2024 22:40

The merge-base changed after approval.

@bc-tgomez bc-tgomez merged commit d3f7759 into main Jan 26, 2024
@bc-tgomez bc-tgomez deleted the DEVDOCS-5379 branch January 26, 2024 22:44
slsriehl pushed a commit that referenced this pull request Jan 29, 2024
…about the default behavior in the description (#60)

<!-- Ticket number or summary of work -->

<!-- Provide a bulleted list in the present tense -->
* Add the default PUT behavior for OrdersV2 in the endpoint description

<!-- Provide an entry for the release notes using simple, conversational
language. Don't be too technical. Explain how the change will benefit
the merchant and link to the feature.

Examples:
* The newly-released [X feature] is now available to use. Now, you’ll be
able to [perform Y action].
* We're happy to announce [X feature], which can help you [perform Y
action].
* [X feature] helps you to create [Y response] using the [Z query
parameter]. Now, you can deliver [ex, localized shopping experiences for
your customers].
* Fixed a bug in the [X endpoint]. Now the [Y field] will appear when
you click [Z option]. -->
* Does this need one if it's an omission?

<!-- Add related PRs, salient notes, additional ticket numbers, etc. -->

ping @bc-vincent-zhao

[DEVDOCS-5379]:
https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5379?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Traci Porter <traci.porter@bigcommerce.com>
bc-tgomez added a commit that referenced this pull request Apr 26, 2024
…about the default behavior in the description (#60)

<!-- Ticket number or summary of work -->

<!-- Provide a bulleted list in the present tense -->
* Add the default PUT behavior for OrdersV2 in the endpoint description

<!-- Provide an entry for the release notes using simple, conversational
language. Don't be too technical. Explain how the change will benefit
the merchant and link to the feature.

Examples:
* The newly-released [X feature] is now available to use. Now, you’ll be
able to [perform Y action].
* We're happy to announce [X feature], which can help you [perform Y
action].
* [X feature] helps you to create [Y response] using the [Z query
parameter]. Now, you can deliver [ex, localized shopping experiences for
your customers].
* Fixed a bug in the [X endpoint]. Now the [Y field] will appear when
you click [Z option]. -->
* Does this need one if it's an omission?

<!-- Add related PRs, salient notes, additional ticket numbers, etc. -->

ping @bc-vincent-zhao

[DEVDOCS-5379]:
https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5379?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Traci Porter <traci.porter@bigcommerce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-SME-review A subject matter expert is needed to review. ready for review This PR is complete and awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants