DEVDOCS-5710 [add]: Metafields, add metafields batch endpoints#63
Merged
bc-andreadao merged 45 commits intomainfrom Feb 9, 2024
Merged
DEVDOCS-5710 [add]: Metafields, add metafields batch endpoints#63bc-andreadao merged 45 commits intomainfrom
bc-andreadao merged 45 commits intomainfrom
Conversation
added 9 commits
January 25, 2024 11:14
added 12 commits
January 31, 2024 11:32
slsriehl
reviewed
Feb 6, 2024
slsriehl
reviewed
Feb 6, 2024
slsriehl
reviewed
Feb 6, 2024
slsriehl
reviewed
Feb 6, 2024
slsriehl
reviewed
Feb 6, 2024
slsriehl
reviewed
Feb 6, 2024
Contributor
Author
|
@bc-tayvs Thanks for the review. Based on your comments (and my testing), I changed the following for the responses:
I also changed the type for the For your comments on old code/endpoints: I created a new ticket (DEVDOCS-5770), so this PR can focus only on batch endpoints. Let me know if there's anything else |
Contributor
422 is a partial success, so result could contain data as well as errors. Plz, make data field not empty for this case. |
bc-tayvs
previously approved these changes
Feb 8, 2024
added 2 commits
February 9, 2024 10:26
…gcommerce/docs into DEVDOCS-5710-metafields-batch
Contributor
Author
|
@bc-tayvs Thanks, just changed the 422 responses so data field isn't empty |
bc-tgomez
previously approved these changes
Feb 9, 2024
bc-traciporter
approved these changes
Feb 9, 2024
Contributor
Author
bc-tgomez
pushed a commit
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVDOCS-5710
What changed?
Release notes draft
Related PR