Skip to content

DEVDOCS-5897: [update] add new headless workflow#630

Merged
becomevocal merged 11 commits intomainfrom
DEVDOCS-5897
Dec 11, 2024
Merged

DEVDOCS-5897: [update] add new headless workflow#630
becomevocal merged 11 commits intomainfrom
DEVDOCS-5897

Conversation

@bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Nov 4, 2024

DEVDOCS-5897

What changed?

added the workflow using the customer access token

Release notes draft

Anything else?

ping {names}

@bc-traciporter
Copy link
Contributor Author

bc-traciporter commented Nov 7, 2024

Hi @kskomro and @bc-0dp those were all very good. Thank you, I feel that I understand the changes better now. When you get a chance can you review the updates?

Also, should I write {{storefront token}} or {{STOREFRONT_TOKEN}}? I see both ways in our docs.

@kskomro
Copy link
Contributor

kskomro commented Nov 12, 2024

Hi @kskomro and @bc-0dp those were all very good. Thank you, I feel that I understand the changes better now. When you get a chance can you review the updates?

Also, should I write {{storefront token}} or {{STOREFRONT_TOKEN}}? I see both ways in our docs.

I think we should be consistent. I would vote for using {{STOREFRONT_TOKEN}}.

@bc-traciporter bc-traciporter requested review from bookernath and removed request for bc-0dp November 13, 2024 19:22
bookernath
bookernath previously approved these changes Dec 3, 2024
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, good to merge after those 2 tweaks

@bc-traciporter
Copy link
Contributor Author

@bookernath do these changes look good? I addressed your two comments.

@becomevocal becomevocal merged commit ff21902 into main Dec 11, 2024
@becomevocal becomevocal deleted the DEVDOCS-5897 branch December 11, 2024 13:31
@bc-traciporter
Copy link
Contributor Author

Thank you @becomevocal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants