Skip to content

DEVDOCS-6320: [update] Update a Web Analytics Provider request body#871

Merged
bc-traciporter merged 3 commits intomainfrom
DEVDOCS-6320
Mar 26, 2025
Merged

DEVDOCS-6320: [update] Update a Web Analytics Provider request body#871
bc-traciporter merged 3 commits intomainfrom
DEVDOCS-6320

Conversation

@bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Mar 19, 2025

DEVDOCS-6320

What changed?

Removed channel_id and id from the Update a Web Analytics Provider request body

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Mar 19, 2025
Copy link

@bc-rmalyavc bc-rmalyavc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are only removing channel_id from body here. We need to also add it as a GET parameter. This is the only way to update web analytics on channel level. We need to reflect it in the docs.

@bc-rmalyavc
Copy link

Looks like we are only removing channel_id from body here. We need to also add it as a GET parameter. This is the only way to update web analytics on channel level. We need to reflect it in the docs.

It turns out that we already have it in parameters. All good then

Copy link

@bc-rmalyavc bc-rmalyavc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bc-terra bc-terra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bc-traciporter bc-traciporter merged commit 7cc975f into main Mar 26, 2025
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-6320 branch March 26, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is complete and awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants