Skip to content

docs(tax): TAX-1750 add type field to tax properties API docs#922

Merged
declankirk merged 1 commit intomainfrom
TAX-1750
Apr 30, 2025
Merged

docs(tax): TAX-1750 add type field to tax properties API docs#922
declankirk merged 1 commit intomainfrom
TAX-1750

Conversation

@declankirk
Copy link
Contributor

@declankirk declankirk commented Apr 29, 2025

TAX-1750

What changed?

  • Adding a new type field to dictate whether property is associated to PRODUCT or CUSTOMER
  • Currently, field is optional and has a default value of PRODUCT

Release notes draft

  • The new /tax/customers endpoint (for configuring customers with said properties) will be documented on a seperate page, in a seperate PR.

ping @bigcommerce/team-tax

@declankirk declankirk marked this pull request as ready for review April 29, 2025 01:36
@declankirk declankirk requested a review from a team April 29, 2025 01:55
bc-msung
bc-msung previously approved these changes Apr 29, 2025
Copy link
Contributor

@theromulans theromulans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the PUT adjustment 🙏 Cheers sir.

Copy link
Collaborator

@bc-terra bc-terra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look good.

Copy link
Contributor

@theromulans theromulans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@declankirk declankirk merged commit 0cfd130 into main Apr 30, 2025
3 checks passed
@declankirk declankirk deleted the TAX-1750 branch April 30, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants