STRF-9112 Improve langJson javascript helper#234
STRF-9112 Improve langJson javascript helper#234junedkazi merged 1 commit intobigcommerce:masterfrom
Conversation
| @@ -11,34 +11,27 @@ | |||
| * @returns {Object.<string, string|Object>} | |||
| */ | |||
| function filterByKey(language, keyFilter) { | |||
junedkazi
left a comment
There was a problem hiding this comment.
Can you also attach some metrics to show the before and after improvements
|
@junedkazi I've added a screenshot of the current measurement on the second call. |
|
You should also look at https://github.com/bigcommerce/paper/pull/218/files @mattolson had some performance improvements specially in the same file you are working on. I wonder if we should get Matt's changes rebased and merged first ? cc @jmwiese |
|
@junedkazi We can test them in the graalvm, but those changes are mostly in languages transformation, that part was moved to storefront service. |
|
@junedkazi Could you please merge it, since I don't have rights for that? |


I believe Object.entries are being slow on GraalVM, so refactored it using simple
forcc @bigcommerce/storefront-team
