Skip to content

fix: TRAC-513 - clear stale variation override on stencil pull#1374

Merged
parthshahp merged 1 commit into
masterfrom
trac-513
May 14, 2026
Merged

fix: TRAC-513 - clear stale variation override on stencil pull#1374
parthshahp merged 1 commit into
masterfrom
trac-513

Conversation

@parthshahp
Copy link
Copy Markdown
Contributor

@parthshahp parthshahp commented May 13, 2026

Summary

  • stencil pull was failing to clear a previously-stored variation value when the corresponding Page Builder field was emptied — the stale value persisted locally even after re-pulling.
  • Root cause: mergeThemeConfiguration compared each remote setting only against the top-level default in config.json. When a Page Builder field was cleared, the remote variation value matched the default, so the loop thought "in sync" and never overwrote the stale variation.settings[key].
  • Fix: compare the remote value against the effective local value — the variation override if one exists, otherwise the default — so stale overrides get cleared back to the default.

Linear: LTRAC-528 · Jira: TRAC-513

Testing

Screen.Recording.2026-05-14.at.10.34.58.AM.mov

@parthshahp parthshahp marked this pull request as ready for review May 14, 2026 14:36
@parthshahp parthshahp merged commit 05cc17d into master May 14, 2026
9 checks passed
@parthshahp parthshahp deleted the trac-513 branch May 14, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants