feat(storefront): strf-9832 Inconsistent behavior for FM in custom templates:#983
Merged
bc-max merged 1 commit intobigcommerce:masterfrom Sep 22, 2022
bc-max:STRF-9832-Inconsistent-behavior-for-FM-in-custom-templates-between-Stencil-CLI-and-Storefront
Conversation
bc-max
commented
Sep 20, 2022
bc-max
commented
Sep 20, 2022
bc-max
commented
Sep 20, 2022
…mplates: - renderer.module.js - sends additional header to bcapp (customLayouts); - renderer.module.spec.js - tests amended; - index.js - custom layouts added;
bc-max
force-pushed
the
STRF-9832-Inconsistent-behavior-for-FM-in-custom-templates-between-Stencil-CLI-and-Storefront
branch
from
cf911dc to
c08de59
Compare
Contributor
Author
jairo-bc
approved these changes
Sep 21, 2022
Member
Contributor
Author
@chrisboulton I'll create a ticket and we take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Stencil cli mode is currently disrespect frontmatter in custom templates and uses default FM instead which is what set forth in our documentation. However, customers want stencil logic to fit regular mode logic (respects custom templates FM). Here we add information about custom layouts into headers being sent to bcapp where we process FM logic. This is first part of the task. Another part is located in
bcapprepo (where you can find new tested behavior)Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Find screenshots here
cc @bigcommerce/storefront-team