chore: switch iManager dep to Packagist 2.0 stable#44
Merged
Conversation
With bigins/imanager 2.0.0 published on Packagist, the workarounds
the rewrite phase needed to consume the library from a sibling
checkout are no longer necessary.
composer.json:
- Constraint `bigins/imanager: 2.0.x-dev` → `^2.0`.
- `repositories: [ {type: path, url: ../imanager, ...} ]` removed.
- `minimum-stability: dev` + `prefer-stable: true` removed
(Composer's stable default applies).
composer.lock regenerated against Packagist's 2.0.0 dist
(`231ca442cb00014d8c1f86d32e91e54a55f2ce08`). Verified locally:
`vendor/bigins/imanager` is now a real package directory, not a
symlink, and the live ServBay-served install (`https://scriptor.cms`
and `/editor/`) returns 200 on both routes against the new package
copy.
Demo image:
- `docker/Dockerfile` drops the `php /tmp/composer-rewrite.php`
step and the `COPY` that brought the helper in. `composer.lock`
is no longer removed before install. Now: a plain
`composer install --no-dev --no-interaction --prefer-dist
--optimize-autoloader`.
- `docker/composer-rewrite.php` deleted — it existed solely to
patch the `repositories` array at build time so a Packagist-less
build could find iManager via a VCS repo. Verified end-to-end on
a fresh clone: `docker compose down -v && docker compose up -d
--build` boots both containers healthy, `/` and `/editor/` return
200, and `vendor/composer/installed.json` confirms
`bigins/imanager 2.0.0` was pulled from Packagist (not from
GitHub VCS, not from a sibling path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With bigins/imanager 2.0.0 published on Packagist, the workarounds the rewrite phase needed to consume the library from a sibling checkout are no longer necessary.
composer.json:
bigins/imanager: 2.0.x-dev→^2.0.repositories: [ {type: path, url: ../imanager, ...} ]removed.minimum-stability: dev+prefer-stable: trueremoved (Composer's stable default applies).composer.lock regenerated against Packagist's 2.0.0 dist (
231ca442cb00014d8c1f86d32e91e54a55f2ce08). Verified locally:vendor/bigins/imanageris now a real package directory, not a symlink, and the live ServBay-served install (https://scriptor.cmsand/editor/) returns 200 on both routes against the new package copy.Demo image:
docker/Dockerfiledrops thephp /tmp/composer-rewrite.phpstep and theCOPYthat brought the helper in.composer.lockis no longer removed before install. Now: a plaincomposer install --no-dev --no-interaction --prefer-dist --optimize-autoloader.docker/composer-rewrite.phpdeleted — it existed solely to patch therepositoriesarray at build time so a Packagist-less build could find iManager via a VCS repo. Verified end-to-end on a fresh clone:docker compose down -v && docker compose up -d --buildboots both containers healthy,/and/editor/return 200, andvendor/composer/installed.jsonconfirmsbigins/imanager 2.0.0was pulled from Packagist (not from GitHub VCS, not from a sibling path).