fix(url): trust X-Forwarded-Proto for site URL scheme#51
Merged
Conversation
Both Site::detectSiteUrl and Editor::detectSiteUrl looked only at
$_SERVER['HTTPS'], which is unset when PHP sits behind a TLS-terminating
reverse proxy (nginx-proxy, traefik, …). Result: every absolute URL
the templates emit (asset hrefs, form actions, navigation links) was
http:// even though the page itself was served over https — every
modern browser blocks the assets as Mixed Content.
Now both check HTTP_X_FORWARDED_PROTO first, falling back to the
$_SERVER['HTTPS'] heuristic. First value wins for chained proxies
('https,http') so a downstream http hop can't downgrade the scheme.
Verified by hitting https://demos.scriptor-cms.dev (nginx-proxy +
acme-companion on Hetzner) — no more Mixed Content warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Site::detectSiteUrl and Editor::detectSiteUrl looked only at $_SERVER['HTTPS'], which is unset when PHP sits behind a TLS-terminating reverse proxy (nginx-proxy, traefik, …). Result: every absolute URL the templates emit (asset hrefs, form actions, navigation links) was http:// even though the page itself was served over https — every modern browser blocks the assets as Mixed Content.
Now both check HTTP_X_FORWARDED_PROTO first, falling back to the $_SERVER['HTTPS'] heuristic. First value wins for chained proxies ('https,http') so a downstream http hop can't downgrade the scheme.
Verified by hitting https://demos.scriptor-cms.dev (nginx-proxy + acme-companion on Hetzner) — no more Mixed Content warnings.