chore(security): harden response headers + session cookie#57
Merged
Conversation
Editor's IMSESSID cookie now ships with HttpOnly, SameSite=Lax, and Secure when the request is HTTPS (direct or via X-Forwarded-Proto from a TLS-terminating proxy). nginx no longer leaks its version, php no longer emits X-Powered-By, and every response carries CSP, X-Content- Type-Options, X-Frame-Options, Referrer-Policy, and Permissions-Policy. CSP is tight (no script-src 'unsafe-inline') but allow-lists cdn.jsdelivr.net since the basic theme pulls UIkit from there. style-src keeps 'unsafe-inline' because UIkit / jQuery inject inline style attributes at runtime. Verified via curl + a full editor login smoke test against the local docker stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor's IMSESSID cookie now ships with HttpOnly, SameSite=Lax, and Secure when the request is HTTPS (direct or via X-Forwarded-Proto from a TLS-terminating proxy). nginx no longer leaks its version, php no longer emits X-Powered-By, and every response carries CSP, X-Content- Type-Options, X-Frame-Options, Referrer-Policy, and Permissions-Policy.
CSP is tight (no script-src 'unsafe-inline') but allow-lists cdn.jsdelivr.net since the basic theme pulls UIkit from there. style-src keeps 'unsafe-inline' because UIkit / jQuery inject inline style attributes at runtime.
Verified via curl + a full editor login smoke test against the local docker stack.