Skip to content
This repository was archived by the owner on Aug 29, 2022. It is now read-only.

Conversation

@zwaldowski
Copy link
Contributor

Closes #281.

@zwaldowski zwaldowski force-pushed the zwaldowski/and-then-progress branch from 495095d to 13d1b58 Compare April 9, 2019 03:44
@piercifani
Copy link
Contributor

piercifani commented Apr 9, 2019

I don't know if this is ready yet, but checking it out on my local project doesn't seem to show any improvements

Here is the log output of the main Task:

Test Case '-[Tests.APIClientTests testGetAndUpload]' started.
CompleteTask 0.009523809523809525
CompleteTask 0.05714285714285714
CompleteTask 0.06619047619047619
CompleteTask 0.9619047619047619
Test Case '-[Tests.APIClientTests testGetAndUpload]' passed (2.045 seconds).

@zwaldowski
Copy link
Contributor Author

I'm trying a few more things.

Make sure you're cleaning as you change the files owned by CocoaPods.

This branch runs like this for me in your testGetAndUpload():

CompleteTask 0.05714285714285714
CompleteTask 0.9619047619047619
CompleteTask 0.9714285714285714
CompleteTask 0.9809523809523809
CompleteTask 0.9904761904761905
CompleteTask 0.5098039215686274
CompleteTask 0.5142156862745098
UploadTask 0.009615384615384616
CompleteTask 0.5186274509803922
UploadTask 0.01826923076923077
CompleteTask 0.5142156862745098
UploadTask 0.009615384615384616
CompleteTask 0.5955882352941176
UploadTask 0.17596153846153847
CompleteTask 0.6367647058823529
UploadTask 0.25961538461538464
CompleteTask 0.6779411764705883
UploadTask 0.34326923076923077
CompleteTask 0.7181372549019608
UploadTask 0.42596153846153845
CompleteTask 0.759313725490196
UploadTask 0.5096153846153846
CompleteTask 0.8004901960784314
UploadTask 0.5932692307692308
CompleteTask 0.8411764705882353
UploadTask 0.676923076923077
CompleteTask 0.8823529411764706
UploadTask 0.760576923076923
CompleteTask 0.9230392156862746
UploadTask 0.8432692307692308
CompleteTask 0.9622549019607843
UploadTask 0.9230769230769231
CompleteTask 0.9627450980392157
UploadTask 0.9240384615384616
CompleteTask 0.9632352941176471
UploadTask 0.925
UploadTask 0.9259615384615385
CompleteTask 0.9637254901960784
UploadTask 0.926923076923077
CompleteTask 0.9642156862745098
UploadTask 0.9278846153846154
CompleteTask 0.9647058823529412
UploadTask 0.9288461538461539
CompleteTask 0.9651960784313726
UploadTask 0.9298076923076923
CompleteTask 0.9656862745098039
UploadTask 0.9307692307692308
CompleteTask 0.9661764705882353
UploadTask 0.9317307692307693
CompleteTask 0.9666666666666667
UploadTask 0.9326923076923077
CompleteTask 0.967156862745098
UploadTask 0.9336538461538462
CompleteTask 0.9676470588235294
UploadTask 0.9346153846153846
CompleteTask 0.9857843137254902
UploadTask 0.9711538461538461
CompleteTask 0.9901960784313726
UploadTask 0.9807692307692307
CompleteTask 0.9950980392156863
UploadTask 0.9903846153846154
CompleteTask 1.0
UploadTask 1.0

@piercifani
Copy link
Contributor

True, it was Cocoapods not linking the right version... sorry about that!

The only weird thing now is that it looks like fractionCompleted goes all the way to 0.99 and then moves down to 0.5, that might be strange for the user...

@zwaldowski
Copy link
Contributor Author

Yes, CompleteTask shouldn't be getting up to 99% initially. I'll follow up.

@piercifani
Copy link
Contributor

Thanks a lot @zwaldowski 🙏

@zwaldowski zwaldowski force-pushed the zwaldowski/and-then-progress branch 2 times, most recently from f3fc774 to e1dc638 Compare April 10, 2019 06:02
@zwaldowski zwaldowski force-pushed the zwaldowski/and-then-progress branch from e1dc638 to 9cb92c4 Compare April 10, 2019 14:37
@zwaldowski zwaldowski merged commit a7ae402 into master Apr 11, 2019
@zwaldowski zwaldowski deleted the zwaldowski/and-then-progress branch April 11, 2019 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants