[requirements] fix format#94
Merged
Merged
Conversation
as `setup.py` pulls this file into `install_requires` - we have to support both formats - that of `setup.py` and that of `pip -r requirements.txt`, so this PR makes it possible.
ofirpress
pushed a commit
to ofirpress/Megatron-DeepSpeed
that referenced
this pull request
Sep 23, 2021
as `setup.py` pulls this file into `install_requires` - we have to support both formats - that of `setup.py` and that of `pip -r requirements.txt`, so this PR makes it possible.
SaulLu
added a commit
to SaulLu/Megatron-DeepSpeed
that referenced
this pull request
Sep 24, 2021
This reverts commit 22a6e17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as
setup.pypulls this file intoinstall_requires- we have to support both formats - that ofsetup.pyand that ofpip -r requirements.txt, so this PR makes it possible.Thanks to SO thread: https://stackoverflow.com/questions/32688688/how-to-write-setup-py-to-include-a-git-repository-as-a-dependency